Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Apptainer" instead of "Singularity" #846

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

arokem
Copy link
Contributor

@arokem arokem commented Nov 7, 2024

"Sigularity" => "Singularity"

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (0e21c37) to head (4f11bae).

Files with missing lines Patch % Lines
qsiprep/utils/bids.py 9.09% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   28.57%   28.54%   -0.03%     
==========================================
  Files          68       68              
  Lines       10126    10137      +11     
  Branches     1135     1137       +2     
==========================================
+ Hits         2893     2894       +1     
- Misses       7134     7143       +9     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member

tsalo commented Nov 8, 2024

@arokem should we change Singularity to Apptainer throughout the documentation?

@arokem
Copy link
Contributor Author

arokem commented Nov 8, 2024

I'll do some more work here to include apptainer and explain that it's sorta the same thing.

@arokem arokem changed the title Fix small typo in installation instruction Use "Apptainer" instead of "Singularity" Nov 11, 2024
@arokem
Copy link
Contributor Author

arokem commented Nov 11, 2024

I've added "Apptainer" in more places. In some places it seems warranted to have both Singularity and Apptainer, just in case (?)

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo tsalo merged commit 49fcb64 into PennLINC:master Nov 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants