Infer the appropriate MNIInfant cohort based on the participant's age #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses code from Nibabies so we need to figure out the appropriate licensing stuff.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 28.76% 28.57% -0.19%
==========================================
Files 68 68
Lines 10025 10123 +98
Branches 1109 1134 +25
==========================================
+ Hits 2884 2893 +9
- Misses 7042 7131 +89
Partials 99 99 ☔ View full report in Codecov by Sentry. |
tsalo
added
enhancement
tsalo
commented
Nov 8, 2024
Comment on lines
-1217
to
+1221
| **{"from": config.workflow.anatomical_template}, | ||
| **{"from": anatomical_template}, |
There was a problem hiding this comment.
@mattcieslak I think the only output change will be to these transform files. Instead of from-MNIInfant_to-T1w and vice versa, it'll be from-MNIInfant+<cohort>_to-T1w.
There was a problem hiding this comment.
That will have implications for QSIRecon though.
There was a problem hiding this comment.
We're updating that part of qsirecon right now anyways, so this should be ok
mattcieslak
approved these changes
Nov 10, 2024
|
|
||
| https://www.nipreps.org/community/licensing/ | ||
|
|
||
| """ |
There was a problem hiding this comment.
thanks for adding this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #826.
Changes proposed in this pull request
--infantrequire--subject-anatomical-reference sessionsince age can't be inferred across sessions.