Skip to content

Commit

Permalink
fix: remove extra v prefix in release workflow !cosmetic
Browse files Browse the repository at this point in the history
* also limit PR comments to repo owner until refactor

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
  • Loading branch information
sarnold authored and bakert committed Nov 24, 2021
1 parent 0b05298 commit c697f74
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# needs separate jobs for coverage checkout/run and PR coverage report comment
# badge and comment job logic should be tuned for personal vs org use
# (see badge job comments below)
# as of Nov 2021: broken on forks, needs much refactoring for previous behavior
name: Coverage

on:
Expand Down Expand Up @@ -199,7 +200,7 @@ jobs:

- name: Add Coverage PR Comment
uses: marocchino/sticky-pull-request-comment@v2.2.0
if: ${{ github.event_name == 'pull_request' }}
if: ${{ github.event_name == 'pull_request' && github.actor == github.repository_owner }}
with:
header: coverage
path: pr-coverage/code-coverage-results.md
Expand Down Expand Up @@ -230,6 +231,7 @@ jobs:
name: Comment on PR with coverage delta
runs-on: ubuntu-20.04
needs: [test, base]
if: ${{ github.actor == github.repository_owner }}

steps:
- name: Environment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ env.VERSION }}
name: Release v${{ env.VERSION }}
name: Release ${{ env.VERSION }}
body_path: CHANGES.md
draft: false
prerelease: false
Expand Down

0 comments on commit c697f74

Please sign in to comment.