Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow and test driver fixes #18

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

sarnold
Copy link

@sarnold sarnold commented Apr 17, 2022

The main points:

plus some other tox, workflow, and packaging updates.

sarnold added 2 commits April 16, 2022 11:56
* increase fetch depth and update regex
* updated action deps, relaxed run criteria
* go back to "normal" tokens, remove permission hacks
* still needs more job isolation => refactor for another day

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
* also fix missing PR event check in coverage workflow

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold
Copy link
Author

sarnold commented Apr 17, 2022

So, how often are you doing "internal" org PRs vs (contributed) PRs from forks?

Certainly one alternative is just ditch this coverage workflow and use one of the usual coveralls/codecov/whatever provider actions. Lemme know if I should delete it, otherwise this one does work for org PRs (if people are working directly in the repositories) but PR comment bits will not work on forked PRs without a bunch of isolation and passing data from one job/step to another. Sadly I didn't find any GH docs or working examples/issues :/

* nose (unmaintained) breaks on python 3.10
* remove some cruft from spectesting.py
* update tox file, move deps to setup.cfg
* restrict PR comment to org owners, adjust

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
* update coverage value for delta/base, allow digits only

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@bakert
Copy link
Member

bakert commented May 31, 2022

@sarnold – Activity has been close to zero so I don't think we have a standard set of behaviors yet. I'm loathe to delete any tests/workflows that are currently working and potentially useful. Is this PR merge-able? The build system seems to think so.

@bakert bakert merged commit c4239ce into PennyDreadfulMTG:master Jun 6, 2022
@sarnold sarnold deleted the mst-upstream branch September 15, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PKG-INFO and pypi report the homepage as sarnold's fork, not ours
2 participants