Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action workflow to notify on main jobs failures #690

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

smokingroosters
Copy link
Contributor

@smokingroosters smokingroosters commented Apr 26, 2024

Context:
It is useful to receive notifications whenever a github action workflow running on mail fails. Github has a slack integration that can be configured, but that sends notification for every job in any state(started, cancelled, failed, succeeded). There is an open issue that hasn't been solved for 2 years.
Because of this, a manual job that triggers based on failures of selected job on main is a better approach, and it won't need to add the notification on each single job.

Description of the Change:
A new workflow is added that will send notification to a slack channel(specified in the webhook configuration in the slack settings).

Benefits:
Get notification when specified jobs fails on main

Possible Drawbacks:
None

Related GitHub Issues:
None

@smokingroosters smokingroosters requested a review from dime10 April 26, 2024 20:24
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (2dc781f) to head (25b50a7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   99.15%   98.26%   -0.90%     
==========================================
  Files          64       65       +1     
  Lines        9258     9387     +129     
  Branches      718      735      +17     
==========================================
+ Hits         9180     9224      +44     
- Misses         51      135      +84     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dime10 dime10 merged commit 8073e29 into main Apr 26, 2024
38 of 39 checks passed
@dime10 dime10 deleted the add-notification-job branch April 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants