Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IsingXY operation #2559

Closed
rmoyard opened this issue May 11, 2022 · 2 comments · Fixed by #2649
Closed

Adding IsingXY operation #2559

rmoyard opened this issue May 11, 2022 · 2 comments · Fixed by #2649
Labels
enhancement ✨ New feature or request good first issue Good for newcomers unitaryhack-bounty Dedicated issue awarding a bounty for the Unitary HACK open-source hackathon

Comments

@rmoyard
Copy link
Contributor

rmoyard commented May 11, 2022

Context

We would like to define a new operation called IsingXY, as defined in the PennyLane-Braket plugin.

Steps to take

Adding the operation

  • Adding the IsingXY class and its attributes to pennylane/ops/qubit/parametric_ops.py.
  • Complete its docstring in a similar fashion as for other operations. Make sure the class is accessible through qml.IsingXY.
  • Add its decomposition, matrix, eigenvalues, adjoint and generator.
  • Make sure the operation works with parameters from all interfaces (autograd, torch, tensorflow and jax)

Adding devices support

  • Add support for the operation in the default.qubit and default.mixed devices

Testing

  • Add the matrix to pennylane/tests/gate_data.py
  • Test the gate itself
  • Test the gradients with multiple interfaces (autograd, torch, tensorflow and jax) with an analytical formula.

Notes

You can refer to the implementation and testings of IsingXX, IsingYY and IsingZZ.

As an example, here is the implementation and the testing of the decomposition for the IsingYY operation. The linked test file contains further test cases for IsingYY.

@rmoyard rmoyard added enhancement ✨ New feature or request good first issue Good for newcomers labels May 11, 2022
@antalszava antalszava added the unitaryhack-bounty Dedicated issue awarding a bounty for the Unitary HACK open-source hackathon label May 12, 2022
@ankit27kh ankit27kh mentioned this issue May 25, 2022
@RamAIbot
Copy link

RamAIbot commented Jun 7, 2022

Hi @rmoyard
Is this issue still open for unitary hack 2022?

@rmoyard
Copy link
Contributor Author

rmoyard commented Jun 7, 2022

Hi @RamAIbot, there is one PR #2649 close to merged I would not recommend working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue Good for newcomers unitaryhack-bounty Dedicated issue awarding a bounty for the Unitary HACK open-source hackathon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants