-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsingXY [unitaryhack] #2649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2649 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 249 249
Lines 20150 20185 +35
=======================================
+ Hits 20067 20102 +35
Misses 83 83
Continue to review full report at Codecov.
|
Hi @ankit27kh ! Thank you for your contribution, let me know when it is ready for review. |
hey @rmoyard it is ready for review. you can take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ankit27kh, you are on a very good way! It misses some coverage and I added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ankit27kh, some minor comments to be solved. After that I am happy to approve the PR 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, can you retrigger the CI checks with git commit --allow-empty -m "Trigger CI"
and pushing again.
Sorry @ankit27kh we reached a concurrency limit again, can you redo it? Thank you! |
Hey @rmoyard, it's finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats @ankit27kh, PR accepted 💯
Context:
Add IsingXY gate
Description of the Change:
Adds the gate and related methods and tests.
Benefits:
Now supports
IsingXY
Possible Drawbacks:
N/A
Related GitHub Issues:
Closes #2559