Revert recent improvement to qml.grad until closer to the next release #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 154 154
Lines 11658 11652 -6
==========================================
- Hits 11393 11387 -6
Misses 265 265 ☔ View full report in Codecov by Sentry. |
mariaschuld
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: PR #1067 introduced an improvement to
qml.grad, which removed the need to index into scalar gradients. However, it was determined that we did not want the behaviour of 0.15.0-dev to diverge from 0.14.0 until further in the release cycle.Description of the Change: Reverts the change of #1067
Benefits: The same code for extracting the gradient of scalar functions will work on both 0.15.0-dev and 0.14.0
Possible Drawbacks: n/a
Related GitHub Issues: n/a