-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BasisEmbedding to allow only-1 bitstrings #1114
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 94.94% 97.74% +2.79%
==========================================
Files 155 155
Lines 11753 11753
==========================================
+ Hits 11159 11488 +329
+ Misses 594 265 -329
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mariaschuld for getting to this so quickly!
Even though this is very trivial, should we add tests for the all zeros and all ones case, just to make sure it is correctly validated? This will also help catch similar bugs in the future.
Co-authored-by: Josh Izaac <josh146@gmail.com>
Good idea, added new test cases... |
Fixes issue #1112.