Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Single Excitation operations #1121
Adds Single Excitation operations #1121
Changes from 59 commits
c211c02
c9aa6d4
49d231e
143cbe3
5f12bbc
6382dc1
9769875
0521cd2
fa16191
a7c4f97
ae018d5
23e85ed
4cd76e7
882bb77
40b2320
3e9f7ba
62683a1
ac178d3
ced73be
6c7bc21
50be11c
d8343c2
0744aaa
aeb6751
711c72e
e6a00e4
95c450c
1b9121d
08fbb8b
0cc729e
40ffa08
2fedf4c
31c05b0
a0bc66a
af9f449
f141160
6bb3848
2b04db3
21d6dc0
c685a6c
27adb98
a0b8328
be16056
5a8432b
a0846e1
b63561c
0875d71
efb0fc4
63a57d3
ea45124
5e7eae1
346edfa
b142126
95d9abc
0c059ea
d85a148
c297f75
434a9ba
2476d1f
ac05f79
9ec2fd3
9348192
042f2b9
a1ef6f1
1d5fc6b
083c61e
ac42e67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring declares that the function returns
array[complex]
but the matrix elementss
andc
are real, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here regarding the type of the returned array,
jnp.Tensor[float]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably the same here:
tf.Tensor[float]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: while true for JAX and autograd above, in this case the tensor will be complex, since
phi
is cast to complex on line 208. So it should remaintf.Tensor[complex]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention to details! 😄