-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype] Integrating PennyLane with error mitigation #1183
Conversation
Hello. You may have forgotten to update the changelog!
|
try: | ||
from mitiq.mitiq_qiskit import to_qiskit | ||
except ImportError as e: | ||
raise ImportError("The mitiq package is required") from e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that a user may have mitiq
but not have qiskit
and hit this error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
dev.execute = execute | ||
dev.batch_execute = batch_execute | ||
|
||
return dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
return cirq_operation_map | ||
|
||
|
||
def _tape_to_cirq(tape): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a useful enough transform that it deserves not only to be public, but to be in its own module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cool thing is that we have a lot of these transformations already, just wrapped up in a device (e.g., this was from PennyLane-Cirq)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, was thinking the same thing!
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 98.12% 97.34% -0.79%
==========================================
Files 144 145 +1
Lines 10846 10948 +102
==========================================
+ Hits 10643 10657 +14
- Misses 203 291 +88
Continue to review full report at Codecov.
|
Very cool! |
Closing as this was re-implemented in #1813 |
This is a prototype of how error mitigation can be integrated into PennyLane using the
mitiq
package.