-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 4-term parameter shift coefficients #1206
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 145 145
Lines 10985 10985
=======================================
Hits 10779 10779
Misses 206 206
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯 🎊 None of the suggestions are blockers.
Co-authored-by: antalszava <antalszava@gmail.com>
This looks good to me, up to a tiny documentation issue: The latest change of the sign in the CRX docstring would need to be applied to CRY, CRZ and CRot as well, wouldn't it? |
Thanks @dwierichs, have just made them all consistent :) |
Great, thanks for carrying out this PR! :) |
Description of the Change: Updates the four-term parameter-shift rule to use coefficients that minimize the variance as per https://arxiv.org/abs/2104.05695
Benefits: More optimal choice of coefficients
Possible Drawbacks: n/a
Related GitHub Issues: n/a