Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentioning Variables in the architecture diagram #1235

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

antalszava
Copy link
Contributor

Changes the architecture diagram image such that it doesn't mention Variables.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1235 (83f9937) into master (d57e5db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         145      145           
  Lines       10981    10981           
=======================================
  Hits        10775    10775           
  Misses        206      206           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57e5db...83f9937. Read the comment docs.

@antalszava antalszava requested a review from josh146 April 19, 2021 17:57
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR to review @antalszava :)

@antalszava antalszava merged commit 6c5868b into master Apr 19, 2021
@antalszava antalszava deleted the update_arch_diagram branch April 19, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants