Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unitaryHACK] Create a Pytorch simulator #1225 #1360
[unitaryHACK] Create a Pytorch simulator #1225 #1360
Changes from 207 commits
bcdd7bf
a3bff30
9d0f8aa
dd762b8
de5575d
b0ed9d0
f2275d1
1e23c2d
12e455a
0e802ba
3f952b1
7e1eb51
b7f68cb
7bff1f9
d03f75f
3ab9ca0
e81fba1
ed72557
62584e2
cdeeede
5768a3f
1f60f1c
be6f3d5
5c4b79d
7fc758b
e0d7fdf
8b2e78d
5cb82a7
65c5205
6dea4fa
9174bcc
00db293
3950a54
59303c9
cf6df7e
b84c771
5c33df8
dea37a8
542d95f
cc182f3
376d448
aa1432d
ff53099
3d11745
f4877f5
8eff218
b237ea6
4fb5eeb
19b912c
246f9c0
92289be
5eac43e
8bef3cb
f042659
c0bf8b1
b5fbf55
55868be
e27b9a1
62b5141
e3c3986
a9f8b80
d25545a
e84e82b
780a7a0
aa57e0b
d6af59a
19e498e
ac75362
972b1fd
4f64eeb
21daf78
f1a127a
d23f5fc
ecfc209
9314aba
69985ef
c71d91f
d39628f
73b51e5
4302b93
22a4f51
b51ae0f
cfd4dfd
9940a47
124245e
fe6f214
393228c
e75188e
76c23b0
b045f8e
9097567
bff6b63
97ea50a
c5b83e3
93d9c88
03663cd
e2c0773
de49d0b
4a4094d
84bb566
fe65a27
8b442b8
cf16922
256aa04
b4e07e9
0db490e
946b77f
72d02a5
26421d4
f5406df
819c8a9
647a3e4
87922dd
684d0d1
83fee40
5168967
edbc0e9
be57772
db12c2b
577902d
14393b7
70b30f1
bfece02
32cfc75
2f62245
662b0e6
eab9f9d
ad74b74
28c0457
c9b1ce6
5e33e1a
8082ea1
c626508
51edc0c
c7b0851
a1793b9
7cc9b6b
984d4bd
d2432b3
97319f0
eb3cacd
a7f7f90
b0c8a23
53d5de5
45a6f2c
9b30c3b
0d0cbf5
33c1fe0
0058e6f
63f7853
4fa4cb5
a5f7f7e
0e9fba5
9110268
1185952
3320119
b5d973d
710fa6b
bd5aa4c
ecf5ada
f4c854e
62a1f16
1bef7c3
a734ad2
c616e64
2f1a154
7c7172e
bbc08cf
9c032de
9b69fc6
545cb08
a67c595
3e49056
f638f3e
d7ed317
1c05c94
eb2a49e
84e2757
77a57e9
970516e
53f92e8
78f5c6d
01a507f
7b44a6b
0bc0669
7e4fd9b
e40c155
997fcfc
4aa7a73
74710dd
915bb63
aeb4d5d
81c8de6
716a7de
c014d63
9681077
17a5793
81d31b9
ae70fd5
32f2ae7
4fe6381
d5f662e
f2cd2b2
e4e0d3e
d4e7bb3
9ce7501
ba3885a
03a8bfb
7252743
ad9a8b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PCesteban, just wanted to make sure that the suggested updates in
aligned well with the intentions for this method. We've noticed that previously the device might output
numpy
arrays, instead oftorch
tensors (hence the suggestions from before). Let us know if we've missed a use case here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @antalszava, I don't think there is any missed use case to the best of my knowledge.
torch
tensors are a better fit for this method.FYI
@Slimane33 @arshpreetsingh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a GPU device fix, so we can't test it without having a GPU test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the
capabilities
method does get tested, so I don't know what's up with code cov here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albi3ro we discovered yesterday that any instance of
pass
in the code gets ignored by codecov due to a line in the.coveragerc
file. (Even in strings and arguments!) #1555 should fix this 🎉