Add spectrum function to Fourier module #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glassnotes this is still WIP, but maybe you want to check if the idea is sound? |
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 158 159 +1
Lines 11780 11832 +52
=======================================
+ Hits 11568 11620 +52
Misses 212 212
Continue to review full report at Codecov.
|
…into spectrum_function
glassnotes
reviewed
Jun 2, 2021
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
…into spectrum_function
co9olguy
reviewed
Jun 9, 2021
co9olguy
requested changes
Jun 9, 2021
Co-authored-by: Nathan Killoran <co9olguy@users.noreply.github.com>
Co-authored-by: Nathan Killoran <co9olguy@users.noreply.github.com>
Co-authored-by: Nathan Killoran <co9olguy@users.noreply.github.com>
Co-authored-by: Nathan Killoran <co9olguy@users.noreply.github.com>
Co-authored-by: Nathan Killoran <co9olguy@users.noreply.github.com>
…into spectrum_function
|
Thanks @co9olguy, I hope I can convince you to not add too many more changes :) |
co9olguy
reviewed
Jun 11, 2021
co9olguy
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Recently, PL got a new Fourier module that can be used to investigate the Fourier representation of quantum circuits. Due to unforeseen difficulties we did not merge the function that would analytically derive the Fourier spectrum from a circuit. This is a new attempt with a much simplified scope.
Description of the Change:
Adds
spectrumqnode transform.Benefits:
The new design lets users mark the gates that are considered as input-encoding gates via their
idattribute. It will not try to track parameters, but simply see if the marked gates define generators, and thus support the assumptions of how to compute the Fourier spectrum directly.