Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy deprecations #1466

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Numpy deprecations #1466

merged 6 commits into from
Jul 21, 2021

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Jul 21, 2021 •
edited
Loading

Changes the uses of np.complex and np.object as per the NumPy deprecations from version 1.20: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations.

@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #1466 (e3f35fa) into master (2b451de) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         168      168           
  Lines       12335    12335           
=======================================
  Hits        12124    12124           
  Misses        211      211
Impacted Files Coverage Δ
pennylane/tape/jacobian_tape.py 98.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b451de...e3f35fa. Read the comment docs.

@antalszava antalszava marked this pull request as ready for review July 21, 2021 09:54
@antalszava
Copy link
Contributor Author

[ch7634]

josh146
josh146 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end!

@antalszava antalszava merged commit 4c75826 into master Jul 21, 2021
@antalszava antalszava deleted the numpy_deprecations branch July 21, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh146 josh146 josh146 approved these changes

@rmoyard rmoyard Awaiting requested review from rmoyard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antalszava @josh146