make default precision equal to jax.config's jax_enable_x64 #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1485 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 180 180
Lines 12701 12705 +4
=======================================
+ Hits 12488 12492 +4
Misses 213 213
Continue to review full report at Codecov.
|
josh146
reviewed
Jul 30, 2021
josh146
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
@dwierichs nice, your changelog entry is better than my original suggestion
Co-authored-by: Josh Izaac <josh146@gmail.com>
|
Good catch regarding the syntax highlighting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default qubit jax device currently always uses
float32precision.This change makes the device check the status of
jax.config.config.read('jax_enable_x64'), which is the variable set toTrueby jax users to enablefloat64precision (also see the jax gotcha).Benefit
When users consciously change the default of jax' precision, the PennyLane device should play along and now does.
Possible drawbacks
The behaviour changes when
jax.config.config.read('jax_enable_x64')=Truebut into the direction of what users would presumably expect.An alternative method would be to use this update as new default but provide an override
precisionkwarg to allow for explicitly setting the precision.