Improvements to matplotlib drawing style and functionality #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 225 225
Lines 17175 17187 +12
=======================================
+ Hits 16971 16983 +12
Misses 204 204
Continue to review full report at Codecov.
|
rmoyard
reviewed
Nov 29, 2021
|
|
||
| @fontsize.setter | ||
| def fontsize(self, value): | ||
| self._fontsize = value |
There was a problem hiding this comment.
You can add a small docstring here.
| @@ -562,11 +578,13 @@ def _ctrlo_circ(self, layer, wires, options=None): | |||
|
|
|||
| self._ax.add_patch(circ_ctrlo) | |||
|
|
|||
| def CNOT(self, layer, wires, options=None): | |||
| def CNOT(self, layer, wires, control_values=None, options=None): | |||
pennylane/transforms/draw.py
Outdated
| @@ -162,6 +162,7 @@ def draw_mpl(qnode, wire_order=None, show_all_wires=False, decimals=None, **kwar | |||
| show_all_wires (bool): If True, all wires, including empty wires, are printed. | |||
| decimals (int): How many decimal points to include when formatting operation parameters. | |||
| Default ``None`` will omit parameters from operation labels. | |||
| fontsize (float or str): fontsize for text | |||
There was a problem hiding this comment.
Can you give example of what string we can pass as argument?
|
@rmoyard I've double-checked the documentation looks fine, and as long as they look good there, the images are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor PR accomplishes:
fontsizea documented public attributetape_mplanddraw_mplacceptfontsizeas a keyword argumentcontrol_valueskeyword to theCNOTmethod. This will allow easy support for arbitraryMultiControlledXgates.plt.rcParams['lines.color']mpl.patches.FancyBboxPatchforplt.Rectangle. It looks better.This PR will not add active wire notches. That will take enough design work that it will occupy it's own PR.