-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit cutting: Remove circuit cuts that do not result in a disconnection #2260
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
67e57ff
Add check to ensure all fragments are connected to the output
trbromley 4dcc37d
Add test
trbromley 597905e
Merge branch 'master' into qcut_remove_unneeded_subgraphs
trbromley 4477238
Fix test
trbromley 98106f8
Merge branch 'qcut_remove_unneeded_subgraphs' of github.com:XanaduAI/…
trbromley 7dbad6f
Remove nodes
trbromley 387cc78
Merge branch 'master' into qcut_remove_unneeded_subgraphs
trbromley 9d19b7e
Update changelog
trbromley ce83dbb
Switch order
trbromley 8369fc1
Add integration test
trbromley 7e4dead
Fix CI
trbromley a1dad8e
Merge branch 'master' into qcut_remove_unneeded_subgraphs
trbromley 81c660d
Don't use JAX
trbromley 8e6bc60
Add test
trbromley d23eb90
Remove contained nodes
trbromley 809d818
Add to changelog
trbromley b0111c9
Add unit test
trbromley d36c2f7
Merge branch 'master' into qcut_remove_contained_cuts
trbromley 5982e32
Fix changelog
trbromley 2116399
Remove test
trbromley 5d47925
Fix test
trbromley 68507be
Fix pylint
trbromley 8d07e90
Merge branch 'master' into qcut_remove_contained_cuts
trbromley b358d1d
Add clarification
trbromley 5a2d8e3
Merge branch 'master' into qcut_remove_contained_cuts
trbromley b3236fa
Merge branch 'master' into qcut_remove_contained_cuts
trbromley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this have to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The circuit in this test actually has a fully contained cut. Beforehand, we were going over all measurement and preparation configurations even though the cut didn't result in a disconnection. So we'd have a
(4, 4)
tensor with contraction equationa,a