Extend qcut.tape_to_graph to support sampling measurements
#2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 242 242
Lines 19160 19166 +6
=======================================
+ Hits 19031 19037 +6
Misses 129 129
Continue to review full report at Codecov.
|
trbromley
suggested changes
Mar 13, 2022
|
[sc-15861] |
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
trbromley
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Thanks @anthayes92. Please resolve the suggestions, but otherwise approved!
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Many practical applications of quantum circuits require sampling measurements. Here we begin extending the existing manual circuit cutting pipeline to support sampling measurements.
Description of the Change:
The existing
qcut.tape_to_graphmethod has been extended to convert a sampling in the computational basis over all wires in a circuit. The single sampling measurement is converted into distinct nodes in the computational graph; one for each wire.Benefits:
First step toward supporting cutting circuit with sampling measurements.
Possible Drawbacks:
Does not support sample measurements containing observables.Related GitHub Issues:
#2297 sampling with and without observables in a single circuit causes an error. As such, the sample nodes added to the graph contain an explicit projection measurement equivalent to sampling in the computational basis. This is required for later steps in the cutting pipeline when converting subgraphs to fragment tapes.