Hilbert Schmidt templates #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 99.46% 99.47%
=======================================
Files 242 243 +1
Lines 19170 19247 +77
=======================================
+ Hits 19068 19145 +77
Misses 102 102
Continue to review full report at Codecov.
|
…/pennylane into hilbert_schmidt_test
rmoyard
added
review-ready 👌
antalszava
suggested changes
Apr 13, 2022
There was a problem hiding this comment.
This is very thoroughly written, looks very nice! @rmoyard 🎉
Had a few formatting/refactoring/wording suggestions, though no real blockers so would be happy to approve on a second quick pass.
Noticed two additional things in general:
- The changelog entry is missing;
- It seems that 8 linting issues are being uncovered by Codefactor.
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
antalszava
suggested changes
Apr 14, 2022
There was a problem hiding this comment.
@rmoyard great push with polishing 🚀 💯 Very near the finish.
A couple of final comments, some from before.
- Codefactor still seems to have some issues: https://github.com/PennyLaneAI/pennylane/runs/6028015270;
LocalHilbertSchmidtseems to not have an image, would that be intentional?- The new templates should also appear on this page: https://pennylane--2364.org.readthedocs.build/en/2364/introduction/templates.html#other-subroutines . That can be achieved by adding a card for the two templates in the
doc/introduction/templates.rstfile; - Also, the docs check seems to be failing: https://github.com/PennyLaneAI/pennylane/runs/6028888508?check_suite_focus=true.
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
From this paper about compilation of quantum circuits with quantum computers, it appears that some templates are useful for PennyLane, Hilbert Schmidt test and local Hilbert Schmidt test.
Description of the Change:
Add two templates
HilbertSchmidtandHilbertSchmidtLocalthat can be used to implement the information quantities from the paper.