-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge qchem and hf modules #2385
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 245 243 -2
Lines 18884 18864 -20
==========================================
- Hits 18776 18756 -20
Misses 108 108
Continue to review full report at Codecov.
|
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Context:
This PR merges the
qml.qchem.hf
andqml.qchem
modules.Description of the Change:
All the modules inside
qml.qchem.hf
are now brought insideqml.qchem
and the originalqchem
modulesobs.py
andstructure.py
are merged into a new moduleopenfermion_obs.py
.Benefits:
The changes are necessary for creating a unifies
qml.qchem
subpackage.Possible Drawbacks:
NA
Related GitHub Issues:
NA