Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compilation transforms support jax.jit (reapply changes) #2397

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

antalszava
Copy link
Contributor

Context:
Reapplies the changes from #1894.

@antalszava antalszava changed the title Make compilation transforms support jax.jit Make compilation transforms support jax.jit (reapply changes) Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2397 (8c20b30) into master (910e95b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   99.43%   99.42%   -0.01%     
==========================================
  Files         245      245              
  Lines       18896    18884      -12     
==========================================
- Hits        18789    18776      -13     
- Misses        107      108       +1     
Impacted Files Coverage Δ
.../transforms/decompositions/single_qubit_unitary.py 100.00% <100.00%> (ø)
...ane/transforms/decompositions/two_qubit_unitary.py 100.00% <100.00%> (ø)
...nnylane/transforms/optimization/merge_rotations.py 97.61% <100.00%> (-2.39%) ⬇️
...lane/transforms/optimization/optimization_utils.py 100.00% <100.00%> (ø)
...ane/transforms/optimization/single_qubit_fusion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910e95b...8c20b30. Read the comment docs.

@antalszava antalszava requested a review from albi3ro March 31, 2022 18:31
@antalszava antalszava marked this pull request as ready for review March 31, 2022 18:42
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you caught this. Looks fine to go for me, assuming the original PR had a thorough review.

@antalszava
Copy link
Contributor Author

Thank you! All thanks for catching it goes to @glassnotes 🎉

@antalszava antalszava merged commit 5674dbc into master Mar 31, 2022
@antalszava antalszava deleted the re_tracer_friendly_compilation branch March 31, 2022 19:19
This was referenced Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants