-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wires to be passed as final positional argument #2432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2432 +/- ##
==========================================
- Coverage 99.47% 99.47% -0.01%
==========================================
Files 245 245
Lines 19495 19493 -2
==========================================
- Hits 19393 19391 -2
Misses 102 102
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straight forward 👍🏼
The Codecov failure seems to be a false negative, overriding the check. |
Currently, the initialization of
Observable
has logic that allows the wires to be passed as the final positional argument.I move this logic to
Operator
to make it more general. This also allows us to get rid of a specific__init__
function forObservable
's.I also tidied two other chunks in the
Operator
initialization function while I was there.