Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pattern_matching function documentation #2489

Closed
wants to merge 16 commits into from
Closed

Improve pattern_matching function documentation #2489

wants to merge 16 commits into from

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Apr 25, 2022

Context:

This PR improves pattern_matching function documentation.

@rmoyard rmoyard changed the base branch from master to v0.23.0-rc0 April 25, 2022 15:42
antalszava
antalszava suggested changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmoyard thank you! 🎉 Left a couple of suggestions for readability.

pennylane/transforms/optimization/pattern_matching.py Outdated Show resolved Hide resolved
pennylane/transforms/optimization/pattern_matching.py Outdated Show resolved Hide resolved
pennylane/transforms/optimization/pattern_matching.py Outdated Show resolved Hide resolved
pennylane/transforms/optimization/pattern_matching.py Outdated Show resolved Hide resolved
pennylane/transforms/optimization/pattern_matching.py Outdated Show resolved Hide resolved
pennylane/transforms/optimization/pattern_matching.py Show resolved Hide resolved
@antalszava antalszava added this to the v0.23.0 milestone Apr 25, 2022
@rmoyard rmoyard requested a review from antalszava April 25, 2022 19:18
antalszava
antalszava approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v0.23.0-rc0@87bcf6e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head fa34936 differs from pull request most recent head a2d6c76. Consider uploading reports for the commit a2d6c76 to get more accurate results

@@              Coverage Diff               @@
##             v0.23.0-rc0    #2489   +/-   ##
==============================================
  Coverage               ?   99.47%           
==============================================
  Files                  ?      244           
  Lines                  ?    19428           
  Branches               ?        0           
==============================================
  Hits                   ?    19326           
  Misses                 ?      102           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bcf6e...a2d6c76. Read the comment docs.

@antalszava antalszava mentioned this pull request Apr 25, 2022
Merged
8 tasks
@antalszava
Copy link
Contributor

Note: the changes of this PR have been directly incorporated in #2474. Closing this PR.

@antalszava antalszava closed this Apr 25, 2022
@trbromley trbromley deleted the update_doc_pattern branch February 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antalszava antalszava antalszava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rmoyard @antalszava