-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hf
dependency in qubit tapering
#2510
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2510 +/- ##
==========================================
- Coverage 99.47% 99.47% -0.01%
==========================================
Files 244 244
Lines 19427 19423 -4
==========================================
- Hits 19325 19321 -4
Misses 102 102
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender, looks good to me, just left few comments and suggestions.
…o qml-tapering-improv
Coverage checks out, overriding the check. |
Context:
This PR removes the dependency of
_generate_qubit_operator
from thehf
module. It also adds a consistency check to manually add wires to the tapered observable if some go missing due to thesimplify()
routine.Description of the Change:
_generate_qubit_operator
fromhf
module with thejordan_wigner
from unifiedqchem
module.qml.taper
. This allows us to return consistent observables in the case of tapering of non-Hamiltonian observables.test_hf_energy
unittest with a newertest_taper_obs
unittest that uses the above consistency check.jordan_wigner
.Benefits:
Removes dependency for the deprecated
hf
module and addresses wires consistency issue with empty simplified tapered observables.Possible Drawbacks:
None.
Related GitHub Issues:
None.