-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve existing linting errors in PennyLane #2528
Conversation
W0404: Reimport 'param_shift_hessian' (imported line 288) (reimported)
E1101: Super of 'NonQueuingTape' has no '_process_queue' member (no-member)
R1725: Consider using Python 3 style super() without arguments (super-with-arguments) W0621: Redefining name 'device' from outer scope (line 89) (redefined-outer-name)
E0611: No name 'sqrt' in module 'pennylane.numpy' (no-name-in-module)
... decorators, dynamic attributes, or other reasons
[sc-17361] |
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 243 243
Lines 19414 19415 +1
=======================================
+ Hits 19323 19324 +1
Misses 91 91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dime10, great updates! 🎉 Have a couple of questions, no blockers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this great work!
Existing linting errors were detected by running
pylint pennylane
from the repository root on master.The errors were resolved in one of 3 ways as shown below, such that running the above command on this branch produces no errors.
Fixed issues
False positives (disable warning)
Won't fix (disable warning)