Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Quickstart: Circuits #2534

Merged
merged 6 commits into from
May 4, 2022
Merged

Improve Quickstart: Circuits #2534

merged 6 commits into from
May 4, 2022

Conversation

mariaschuld
Copy link
Contributor

Updates the circuits section of the quickstarts, as part of a minor overhaul.

Bigger changes:

  • Merge sections on wires and shots
  • Add reference to draw_mlp
  • Delete QNodeCollections section

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2534 (e972b3e) into master (fb797be) will increase coverage by 3.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
+ Coverage   95.78%   99.53%   +3.74%     
==========================================
  Files         243      243              
  Lines       19405    19405              
==========================================
+ Hits        18588    19314     +726     
+ Misses        817       91     -726     
Impacted Files Coverage Δ
pennylane/_qubit_device.py 98.73% <0.00%> (+0.31%) ⬆️
pennylane/devices/default_qubit.py 100.00% <0.00%> (+0.38%) ⬆️
pennylane/utils.py 97.97% <0.00%> (+0.67%) ⬆️
...ane/transforms/optimization/single_qubit_fusion.py 100.00% <0.00%> (+1.92%) ⬆️
pennylane/templates/embeddings/amplitude.py 98.00% <0.00%> (+2.00%) ⬆️
pennylane/gradients/vjp.py 100.00% <0.00%> (+2.89%) ⬆️
pennylane/interfaces/torch.py 100.00% <0.00%> (+3.27%) ⬆️
pennylane/ops/qubit/qchem_ops.py 100.00% <0.00%> (+4.81%) ⬆️
pennylane/devices/default_qubit_torch.py 92.07% <0.00%> (+5.94%) ⬆️
pennylane/ops/qubit/parametric_ops.py 100.00% <0.00%> (+6.68%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb797be...e972b3e. Read the comment docs.

@mariaschuld mariaschuld requested a review from josh146 May 3, 2022 07:38
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and suggestions, but nothing blocking! (except probably the mention of lightning)

doc/introduction/circuits.rst Outdated Show resolved Hide resolved
doc/introduction/circuits.rst Show resolved Hide resolved
doc/introduction/circuits.rst Show resolved Hide resolved
doc/introduction/circuits.rst Outdated Show resolved Hide resolved
doc/introduction/circuits.rst Show resolved Hide resolved
doc/introduction/circuits.rst Outdated Show resolved Hide resolved
doc/introduction/circuits.rst Outdated Show resolved Hide resolved
doc/introduction/circuits.rst Outdated Show resolved Hide resolved
doc/introduction/circuits.rst Show resolved Hide resolved
@mariaschuld mariaschuld merged commit 1d4edcc into master May 4, 2022
@mariaschuld mariaschuld deleted the improve_quickstart_2 branch May 4, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants