Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code coverage #2537

Merged
merged 3 commits into from
May 3, 2022
Merged

Improved code coverage #2537

merged 3 commits into from
May 3, 2022

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented May 3, 2022

This PR handles several lines that were missing code coverage by either:

  • explicitly specifying the lines will not be covered by our tests
  • fixing logic that won't ever be covered
  • adding tests

@albi3ro albi3ro requested a review from antalszava May 3, 2022 20:23
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2537 (2d4538c) into master (705bfd5) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
+ Coverage   99.47%   99.53%   +0.05%     
==========================================
  Files         243      243              
  Lines       19413    19405       -8     
==========================================
+ Hits        19312    19314       +2     
+ Misses        101       91      -10     
Impacted Files Coverage Δ
pennylane/drawer/mpldrawer.py 100.00% <ø> (+1.33%) ⬆️
pennylane/fourier/visualize.py 100.00% <ø> (+1.29%) ⬆️
pennylane/ops/qubit/hamiltonian.py 100.00% <ø> (+0.94%) ⬆️
pennylane/ops/qubit/matrix_ops.py 100.00% <0.00%> (+0.87%) ⬆️
pennylane/ops/functions/generator.py 100.00% <0.00%> (+1.42%) ⬆️
pennylane/fourier/coefficients.py 100.00% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705bfd5...2d4538c. Read the comment docs.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 Thank you 🙂

tests/fourier/test_coefficients.py Show resolved Hide resolved
tests/ops/functions/test_generator.py Outdated Show resolved Hide resolved
Co-authored-by: antalszava <antalszava@gmail.com>
@albi3ro albi3ro merged commit e326486 into master May 3, 2022
@albi3ro albi3ro deleted the improved-coverage branch May 3, 2022 21:02
@antalszava antalszava mentioned this pull request May 9, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants