-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Interface name variations dispatch to correct backprop device #2591
Conversation
[sc-19268] |
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 243 243
Lines 19595 19596 +1
=======================================
+ Hits 19514 19515 +1
Misses 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉 😻 Once the changelog entry is updated, good to merge this from my side.
Fixes #2546
Now if you specify QNodes like:
It will map the device to
default.qubit.tf
and using backpropagation instead of silently switching to a differentdiff_method
.In solving this bug, I substituted
qml.interfaces.INTERFACE_MAP
forqml.interfaces.INTERFACE_NAMES
, which maps in the opposite direction. This allowed from some readability improvements.qml.interfaces.INTERFACE_MAP
maps provided name to canonical name, instead of canonical name to list of acceptable provided names.