-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert device gradients fix #2595
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
===========================================
+ Coverage 72.92% 99.58% +26.65%
===========================================
Files 245 245
Lines 19726 19724 -2
===========================================
+ Hits 14386 19642 +5256
+ Misses 5340 82 -5258
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @puzzleshark! It would be great to add a test case to the test suite as per the suggested example from the relevant issue, such that we can be sure that the problem doesn't arise again.
Also, be sure to add a changelog item. 🙂
…yLaneAI/pennylane into revert-device-gradients-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
[sc-19816]