-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update object's queue metadata if already in the queue #2612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2612 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.02%
==========================================
Files 244 244
Lines 19670 19667 -3
==========================================
- Hits 19590 19585 -5
- Misses 80 82 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just CodeCov 👍🏼
In multiple places across the codebase, we see the pattern:
Currently, the role of object metadata is to indicate whether an operation should be ignored by the tape processing step. So most of the time, there is no reason to queue the object only to mark it as invisible.
This also is a lot of repeated code.
This PR adds a
safe_update_queue
and_safe_update_queue
methods toqml.QueuingContext
that only updates the metadata if the object is in the queue. It will never raiseQueuingError
's.