Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pow Symbolic Operator #2621

Merged
merged 22 commits into from
Jun 3, 2022
Merged

Pow Symbolic Operator #2621

merged 22 commits into from
Jun 3, 2022

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented May 25, 2022

This class mirrors the symbolic operators being introduced in #2222 and #2475 .

This PR will only introduce the symbolic operator and not add a user-facing constructor or device execution support.

@albi3ro albi3ro added the op-arithmetic PR's involved in introducing operator arithmetic label May 25, 2022
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #2621 (09d0324) into master (43fc4f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #2621    +/-   ##
========================================
  Coverage   99.58%   99.58%            
========================================
  Files         248      249     +1     
  Lines       19985    20135   +150     
========================================
+ Hits        19902    20052   +150     
  Misses         83       83            
Impacted Files Coverage Δ
pennylane/math/single_dispatch.py 98.86% <ø> (ø)
pennylane/ops/op_math/__init__.py 100.00% <100.00%> (ø)
pennylane/ops/op_math/pow_class.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fc4f6...09d0324. Read the comment docs.

@albi3ro
Copy link
Contributor Author

albi3ro commented May 27, 2022

[sc-20183]

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a glimpse of the overall operator arithmetic, an amazing push @albi3ro! 🎆 It's apparent that much thought went into the planning and the design here.

Left some comments, many for my own understanding.

pennylane/ops/op_math/__init__.py Outdated Show resolved Hide resolved
pennylane/ops/op_math/pow_class.py Outdated Show resolved Hide resolved
pennylane/ops/op_math/pow_class.py Show resolved Hide resolved
pennylane/ops/op_math/pow_class.py Outdated Show resolved Hide resolved
pennylane/ops/op_math/pow_class.py Outdated Show resolved Hide resolved
tests/ops/op_math/test_pow_op.py Outdated Show resolved Hide resolved
tests/ops/op_math/test_pow_op.py Outdated Show resolved Hide resolved
tests/ops/op_math/test_pow_op.py Show resolved Hide resolved
tests/ops/op_math/test_pow_op.py Show resolved Hide resolved
tests/ops/op_math/test_pow_op.py Show resolved Hide resolved
Co-authored-by: antalszava <antalszava@gmail.com>
Copy link
Contributor

@mariaschuld mariaschuld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I admit I had a superficial review to check the general logic and test coverage, so my "accept" would be subject to at least one more acceptance. But since this recovers the structure of the previous PR I would trust that it works as there.

@albi3ro albi3ro requested a review from antalszava June 2, 2022 19:59
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 🙂 Amazing to see that a consistent and clear structure is being created here. 🏛️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-arithmetic PR's involved in introducing operator arithmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants