-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pow
Symbolic Operator
#2621
Pow
Symbolic Operator
#2621
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 248 249 +1
Lines 19985 20135 +150
========================================
+ Hits 19902 20052 +150
Misses 83 83
Continue to review full report at Codecov.
|
[sc-20183] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a glimpse of the overall operator arithmetic, an amazing push @albi3ro! 🎆 It's apparent that much thought went into the planning and the design here.
Left some comments, many for my own understanding.
Co-authored-by: antalszava <antalszava@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I admit I had a superficial review to check the general logic and test coverage, so my "accept" would be subject to at least one more acceptance. But since this recovers the structure of the previous PR I would trust that it works as there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉 🙂 Amazing to see that a consistent and clear structure is being created here. 🏛️
This class mirrors the symbolic operators being introduced in #2222 and #2475 .
This PR will only introduce the symbolic operator and not add a user-facing constructor or device execution support.