Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Arithmetic Prod wrapper class implementation #2625

Merged
merged 71 commits into from
Aug 3, 2022
Merged

Operator Arithmetic Prod wrapper class implementation #2625

merged 71 commits into from
Aug 3, 2022

Conversation

Jaybsoni
Copy link
Contributor

Context:
Adding the Prod wrapper class to represent tensor and matrix product of operators

albi3ro and others added 30 commits April 1, 2022 15:00
@albi3ro
use object _queue_category attribute for sorting in tapes
17f57da
@albi3ro
Merge branch 'master' into ops-know-queue-type
528b6c4
@albi3ro
black
1ad48e7
@albi3ro
Merge branch 'master' into ops-know-queue-type
74cd1da
@albi3ro
Merge branch 'master' into ops-know-queue-type
c6e10a5
@Jaybsoni
Merge branch 'master' into ops-know-queue-type
d82e670
@Jaybsoni
init commit, transferring prototype of Sum class here for full implem…
894531e 
…entation
@Jaybsoni
playing around with .get_matrix() method
7b119e8
@Jaybsoni
stash
cbff4e6
@Jaybsoni
Merge branch 'master' into sum_wrapper
68b39a8
@Jaybsoni
Merge branch 'sum_wrapper' of https://github.com/PennyLaneAI/pennylane …
e8fe68a 
…into sum_wrapper
@Jaybsoni
got the matrix() functionality working
f2e2d45
@Jaybsoni
Update doc/releases/changelog-dev.md
daa6a91
@Jaybsoni
address some comments
bf5f308
@Jaybsoni
changelog fix
c60b68e
@Jaybsoni
added changelog entry
ea5b801
@Jaybsoni
started creating the test suite
067fb7c
@Jaybsoni
Merge branch 'master' into sum_wrapper
a0569f1
@Jaybsoni
Merge branch 'master' into sum_wrapper
9bcf00c
@Jaybsoni
generalized sum for multi qubit gates, addressed casting issues
3d942c7
@Jaybsoni
Merge branch 'master' into sum_wrapper
eb18cf3
@Jaybsoni
reworking sum logic
fd61697
@Jaybsoni
reworking sum logic
345f01d
@Jaybsoni
adding tests for get_matrix
3eb4511
@Jaybsoni
Initial implementation of wrapper for scalar product operation
bd4fe3f
@Jaybsoni
Merge branch 'master' into sum_wrapper
d40b224
@Jaybsoni
add logic to handle SProd(Sprod)
53e56c0
@Jaybsoni
fixed import in test
05b2032
@Jaybsoni
Merge branch 'sum_wrapper' of https://github.com/PennyLaneAI/pennylane …
e9f058f 
…into sum_wrapper
@Jaybsoni
added Prod wrapper class
eb07397
@Jaybsoni Jaybsoni changed the title [WIP] Operator Arithmetic Prod wrapper class implementation Operator Arithmetic Prod wrapper class implementation Aug 2, 2022
AlbertMitjans
AlbertMitjans approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@AlbertMitjans AlbertMitjans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Just one comment: we may want to use deepcopy for copying data.

pennylane/measurements.py Show resolved Hide resolved
@Jaybsoni Jaybsoni mentioned this pull request Aug 3, 2022
Merged
albi3ro
albi3ro reviewed Aug 3, 2022
View reviewed changes
pennylane/operation.py Outdated Show resolved Hide resolved
Jaybsoni
Jaybsoni commented Aug 3, 2022
View reviewed changes
pennylane/operation.py Outdated Show resolved Hide resolved
@Jaybsoni @albi3ro
Apply suggestions from code review
5d26611 
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
albi3ro approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🎉

@Jaybsoni @albi3ro
Update tests/ops/op_math/test_prod.py
18f8794 
Co-authored-by: Christina Lee <christina@xanadu.ai>
@Jaybsoni Jaybsoni merged commit 14eeb29 into master Aug 3, 2022
@Jaybsoni Jaybsoni deleted the prod_wrapper branch August 3, 2022 20:19
@Jaybsoni
Copy link
Contributor Author

Jaybsoni commented Aug 3, 2022

[sc-20180]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertMitjans AlbertMitjans AlbertMitjans approved these changes

@albi3ro albi3ro albi3ro approved these changes

@josh146 josh146 Awaiting requested review from josh146

@mariaschuld mariaschuld Awaiting requested review from mariaschuld

Assignees

@Jaybsoni Jaybsoni

Labels
op-arithmetic PR's involved in introducing operator arithmetic
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Jaybsoni @josh146 @albi3ro @AlbertMitjans @rmoyard