Move ctrl and ControlledOperation to qml.ops.op_math submodule
#2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2656 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 249 249
Lines 20228 20229 +1
=======================================
+ Hits 20145 20146 +1
Misses 83 83
Continue to review full report at Codecov.
|
albi3ro
commented
Jun 3, 2022
antalszava
reviewed
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
ctrlandControlledOperationto the newqml.ops.op_mathsubmodule, and no longer imports theControlledOperationclass top-level, as it is purely developer-facing.With PR #2634 , we will be adding a new version of
ControlledOperationthat wraps individual operators instead of entire tapes. The new wrapper will also provide more features and eventually replace the many individual controlled operations.