-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unitaryhack] Request for new matplotlib drawing styles #2662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2662 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 249 249
Lines 20256 20280 +24
=======================================
+ Hits 20173 20197 +24
Misses 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trentfridey Thanks for the excellent contribution!
It looks like you've got all the code figured out, which is always nice to see.
Initially, I was going to ask for more contrast between the background and text, but upon viewing them in my dark-themed IDE, they looked wonderful.
One minor change that made the graphics much clearer was:
plt.rcParams['patch.linewidth'] = 3.0
I had to set the 'patch.linewidth'
in the black_white
style as well.
I'd also like to see how qml_drawer.rst
looks with a 3x2 table instead of 5x1. The images start to get a bit too small with 5x1.
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent!
Just need to run black -l 100 pennylane/drawer/style.py
and I'm happy to approve +1
@trentfridey So close! but now it looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Thanks for the great contribution 🎉
Context:
Adds styles requested in #2555
Description of the Change:
Adds the solarized light and dark styles to the available styles for drawer
Benefits:
Adds more options for clean and readable circuit diagram graphics
Related GitHub Issues:
#2555