-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make visual changes for 0 and 1 control values [unitaryhack] #2668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 249 249
Lines 20220 20228 +8
=======================================
+ Hits 20137 20145 +8
Misses 83 83
Continue to review full report at Codecov.
|
Hey @albi3ro, I think this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we didn't update the documentation examples, but I can do that this afternoon. The documentation changes will be easy but extensive because many examples rely on qml.draw
to demonstrate their behaviour.
Thanks for the great suggestion and contribution @ankit27kh ! This will especially be useful going forward as we make our control operations more general.
Context:
Text drawing had no difference between 0 and 1 control values. Similarly, mpl drawer was missing
ControlledQubitUnitary
in its special casesDescription of the Change:
Changes text drawer to have different symbols for 0 and 1 control values.
Also, addAdds logic in mpl drawer to considerControlledQubitUnitary
as a special case in mpl drawer.control_values
Benefits:
Better visual circuits.
Possible Drawbacks:
Related GitHub Issues:
Closes #2660