-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource estimation class for first quantization algorithm #2746
Add resource estimation class for first quantization algorithm #2746
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## resource_estimation_algorithms #2746 +/- ##
===============================================================
Coverage 99.62% 99.62%
===============================================================
Files 257 257
Lines 21112 21122 +10
===============================================================
+ Hits 21032 21042 +10
Misses 80 80
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments mostly on the docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @soranjh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just check the usage details before merging
Context:
This PR adds a class to wrap the functionality for estimating the number of non-Clifford gates and logical qubits for quantum algorithms in first quantization.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: