Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource estimation class for first quantization algorithm #2746

Merged
merged 15 commits into from
Jun 29, 2022

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Jun 19, 2022

Context:
This PR adds a class to wrap the functionality for estimating the number of non-Clifford gates and logical qubits for quantum algorithms in first quantization.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@soranjh soranjh added WIP 🚧 Work-in-progress qchem ⚛️ Related to the QChem package labels Jun 19, 2022
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@soranjh soranjh changed the title Resource firstq class [WIP] add fq resource estimation class Jun 19, 2022
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2746 (83c3afc) into resource_estimation_algorithms (8dde02b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##           resource_estimation_algorithms    #2746   +/-   ##
===============================================================
  Coverage                           99.62%   99.62%           
===============================================================
  Files                                 257      257           
  Lines                               21112    21122   +10     
===============================================================
+ Hits                                21032    21042   +10     
  Misses                                 80       80           
Impacted Files Coverage Δ
pennylane/resources/second_quantization.py 100.00% <ø> (ø)
pennylane/resources/__init__.py 100.00% <100.00%> (ø)
pennylane/resources/first_quantization.py 100.00% <100.00%> (ø)
pennylane/math/quantum.py 100.00% <0.00%> (ø)
pennylane/measurements.py 99.62% <0.00%> (ø)
pennylane/qinfo/transforms.py 100.00% <0.00%> (ø)
pennylane/ops/functions/eigvals.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dde02b...83c3afc. Read the comment docs.

@soranjh soranjh changed the title [WIP] add fq resource estimation class Add resource estimation class for first quantization algorithm Jun 24, 2022
@soranjh soranjh removed the WIP 🚧 Work-in-progress label Jun 24, 2022
@soranjh soranjh changed the base branch from master to resource_estimation_algorithms June 24, 2022 15:48
@soranjh soranjh marked this pull request as ready for review June 24, 2022 15:48
Copy link

@mojishoki mojishoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments mostly on the docstrings

@soranjh soranjh requested a review from mojishoki June 27, 2022 17:49
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @soranjh.

pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
@soranjh soranjh requested a review from ixfoduap June 28, 2022 17:51
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just check the usage details before merging

pennylane/resources/first_quantization.py Outdated Show resolved Hide resolved
@soranjh soranjh merged commit 8d9092a into resource_estimation_algorithms Jun 29, 2022
@soranjh soranjh deleted the resource_firstq_class branch June 29, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qchem ⚛️ Related to the QChem package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants