Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the resource module #2796

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Jul 5, 2022

Context:
This PR creates the qml.resource module for hosting future-facing functionalities such as resource estimation.

Description of the Change:

  • resource module created inside pennylane.
  • factorization.py is moved inside qchem.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@soranjh soranjh changed the title Resource future [WIP] create the future module Jul 5, 2022
@soranjh soranjh added the WIP 🚧 Work-in-progress label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2796 (b8dceab) into resource_estimation_algorithms (9334aaf) will not change coverage.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##           resource_estimation_algorithms    #2796   +/-   ##
===============================================================
  Coverage                           99.62%   99.62%           
===============================================================
  Files                                 261      261           
  Lines                               21278    21278           
===============================================================
  Hits                                21198    21198           
  Misses                                 80       80           
Impacted Files Coverage Δ
pennylane/qchem/factorization.py 100.00% <ø> (ø)
pennylane/resource/__init__.py 100.00% <ø> (ø)
pennylane/resource/first_quantization.py 100.00% <ø> (ø)
pennylane/__init__.py 100.00% <100.00%> (ø)
pennylane/qchem/__init__.py 100.00% <100.00%> (ø)
pennylane/resource/second_quantization.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9334aaf...b8dceab. Read the comment docs.

@soranjh soranjh requested review from ixfoduap and josh146 July 6, 2022 14:20
@soranjh soranjh changed the title [WIP] create the future module [WIP] create the resource module Jul 9, 2022
@soranjh soranjh changed the title [WIP] create the resource module Create the resource module Jul 9, 2022
@soranjh soranjh marked this pull request as ready for review July 9, 2022 23:42
@soranjh soranjh removed the WIP 🚧 Work-in-progress label Jul 9, 2022
pennylane/resource/__init__.py Outdated Show resolved Hide resolved
@ixfoduap ixfoduap merged commit 442047b into resource_estimation_algorithms Jul 13, 2022
@ixfoduap ixfoduap deleted the resource_future branch July 13, 2022 19:47
@rmoyard rmoyard added this to the v0.25.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants