Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom return type #2813

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

cvjjm
Copy link
Contributor

@cvjjm cvjjm commented Jul 14, 2022

This contains suggested improvements to #2808 @puzzleshark

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2813 (d43f958) into custom-return-type (cca0785) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           custom-return-type    #2813   +/-   ##
===================================================
  Coverage               99.62%   99.62%           
===================================================
  Files                     258      258           
  Lines                   21143    21143           
===================================================
  Hits                    21063    21063           
  Misses                     80       80           
Impacted Files Coverage Δ
pennylane/interfaces/autograd.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca0785...d43f958. Read the comment docs.

@puzzleshark puzzleshark merged commit 6e9a17b into PennyLaneAI:custom-return-type Jul 18, 2022
antalszava added a commit that referenced this pull request Jul 27, 2022
* added custom return object

* added comparison

* added more asserts

* progress

* changed description

* Update pennylane/_qubit_device.py

Co-authored-by: antalszava <antalszava@gmail.com>

* Update tests/devices/test_custom_return_obj.py

Co-authored-by: antalszava <antalszava@gmail.com>

* Update tests/devices/test_custom_return_obj.py

Co-authored-by: antalszava <antalszava@gmail.com>

* Custom return type (#2813)

* fix problem from #2808 (comment)

* also test device gradient with custom return type

* Empty-Commit

* fixed formatting for test

* moved test to existing autograd test file

* Update doc/releases/changelog-dev.md

Co-authored-by: antalszava <antalszava@gmail.com>

* reverted

* fixed

* fixed change

* seperated into 2 testcases

* fixed black

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: cvjjm <60615188+cvjjm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants