-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically determine interface from constructed quantum script #3132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3132 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 276 276
Lines 24273 24292 +19
=======================================
+ Hits 24200 24219 +19
Misses 73 73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Christina Lee <christina@xanadu.ai>
…eAI/pennylane into get-interface-support-sequences
Hi @AlbertMitjans, great changes! One thing that should be done is adding those changes to |
We are calling
@albi3ro mentioned that we should first try this out as an optional feature to make sure it works correctly. If it does we can make it the default. |
@AlbertMitjans Thanks for the second point! Our methodology for the return type project is to duplicate the function (one public and one private). Right at the beginning, the public one calls the private one. The private one should be able to replace the public one without having to double check if something is missing (when we will deprecate it). So in this case I would suggest to move the code bloc after the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per Romain's find, will just double-check that the new return-type pipeline works as expected.
Oh OK! I did what you suggested. Thanks for this catch! 🎉 |
Thanks @AlbertMitjans ! 💯 You can add |
Added! @rmoyard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring for QNode
and execute
should be updated to include the option "auto"
.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to have this! 👍 Looks good to me.
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉 Awesome feature, great work 🙂 😍
The
QNode
class now accepts anauto
interface, which automatically detects the interface of the given input.Prints