Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use param-shift too for test_gradient_unitary_to_rot_two_qubit_jax #3183

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Oct 18, 2022

#1412 works now on master - as noted there, this PR adds param-shift as a tested diff_method.

From the issue:

I've just run into this in the development of #1552. Once it is resolved, it would be nice to update the test
test_gradient_unitary_to_rot_two_qubit_jax in the test_unitary_to_rot.py file to include parameter-shift in addition to backprop.

Closes #1412.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3183 (494421d) into master (b728eb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         274      274           
  Lines       23922    23922           
=======================================
  Hits        23848    23848           
  Misses         74       74           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antalszava, great catch 💯

@antalszava antalszava merged commit d82ffc4 into master Oct 18, 2022
@antalszava antalszava deleted the unitary_to_rot_test_param_shift branch October 18, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jax with diff_method "parameter-shift", "finite-diff" and non-trainable parameters
2 participants