-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an adaptive optimizer #3192
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #3192 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 277 278 +1
Lines 24578 24621 +43
=======================================
+ Hits 24505 24548 +43
Misses 73 73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This optimizer is awesome!
I'm making mostly small suggestions, except perhaps the addition of a few more tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just leaving a couple of suggestions.
Context:
This PR adds an adaptive optimizer.
Description of the Change:
The
AdaptiveOptimizer
class is added toqml.optimize
.Benefits:
The new functionality makes it easy for the users to build quantum chemistry circuits adaptively.
Possible Drawbacks:
Related GitHub Issues: