Evolution operator #3375
Evolution operator #3375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3375 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 309 309
Lines 27542 27597 +55
=======================================
+ Hits 27506 27561 +55
Misses 36 36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
There was a problem hiding this comment.
Great work @lillian542, just left some suggestions and comments.
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
* get parameter shift working with evolution operator * Fix bug in Exp.hash * Update tests * Coeff to string in hash * Update test Co-authored-by: Lillian Frederiksen <lillian542@gmail.com>
There was a problem hiding this comment.
Great work! Left some comments for you to address.
Just one suggestion, since this operation doesn't have a top level constructor (eg. for Sum class we have a top level qml.op_sum), I think it might be worth while to just make it available top level. This would require adding an import in the PennyLane init file with from ops import Evolution and would unlock the qml.Evolution() UI
You should confirm with Tom or Josh to make sure this is actually what we want. Otherwise I think it looks great!
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
lillian542
force-pushed
the
evolution_operator
branch
from
9b96a7e
to
ce1ed34
Compare
Jaybsoni
added
the
merge-ready ✔️
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Context:
Expclass does not havegeneratormethod orparameter_frequencyproperty defined, even though these could be defined for some instances ofExp.Expwhere the base operator includes parameters (e.g.0.5*qml.PauliX(0), or any instance ofqml.Hamiltonian), the operator hasnum_params > 1, and standard functions for differentiation via parameter shift, such asqml.generator(op), don't work.Description of the Change:
generatorandparameter_frequencytoExpclass in cases where it is defined (when the coefficient has no real component and the base operator is Hermitian)Evolutionoperator defined to be of the form exp(ixG) with a single, trainable parameter x. This allows differentiation with regards to the parameter x, even in instances where the base operator G contains additional parameters.