-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gamma functions to the math module #3495
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## qchem_jax_addmath #3495 +/- ##
==================================================
Coverage 99.87% 99.87%
==================================================
Files 311 311
Lines 27910 27926 +16
==================================================
+ Hits 27874 27890 +16
Misses 36 36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soranjh for the changes 👍 It think that gammainc would be better a multi dispatch, as the behavior in single dispatch can be misleading. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me 💯 Could you add a unit test in the test_functions
in the math module, nothing too elaborate, just make sure that it is working for different combinations of x and y (builtin, numpy autograd, jax). After that happy to approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soranjh, it looks good 💯 There are some changes in the file `pauli/utils, is it intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soranjh 💯
Context:
The PR adds the gamma function and the incomplete gamma function needed for computing the Boys function to
qml.math
.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: