-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml.evolve
: dispatch function
#3706
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3706 +/- ##
==========================================
- Coverage 99.74% 99.73% -0.01%
==========================================
Files 328 328
Lines 28662 28695 +33
==========================================
+ Hits 28588 28619 +31
- Misses 74 76 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'm not sure about adding
So I'm not convinced it makes things clearer, though I do like having the option to set the |
A rotation operator is considered an evolution? When googling "evolution operator" all the links talk about time evolution. |
This was also my initial response, and I think the name is not ideal. The idea with the operator was a generalized On the original shortcut ticket it was called |
778590d
to
a641f33
Compare
…to refactor-evolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
* 🧪 tests (evolve): Fix tests. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Fix docstring. * 🧪 tests (evolve): Add tests. * ✏️ chore (changelog): Add changelog entry. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Fix docstring. * 🧪 tests (evolve): Fix coverage. * 🔧 refactor (evolve): Dispatch function. * 🔧 refactor (evolve): Dispatch function. * 📝 docs (evolve): Fix docstring. * 🧪 tests (evolve): Fix tests. * 📝 docs (evolve): Fix sphinx. * ⏪ revert (evolve): Remove t and dt from parametrized_evolution. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Fix docstring. * Update pennylane/ops/functions/evolve.py Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> * Update pennylane/ops/functions/evolve.py Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> * 📝 docs (evolve): Update evolve docstring. * 📝 docs (evolve): Update evolve docstring. * 📝 docs (evolve): Fix sphinx. * 📝 docs (evolve): Test sphinx. * 📝 docs (evolve): Test sphinx. * 📝 docs (evolve): Use html. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Test sphinx. * 📝 docs (evolve): Test sphinx. * 📝 docs (evolve): Fix docstring. * 📝 docs (evolve): Fix docstring. * 🐛 fix (evolve): Remove op from initial call. * 📝 docs (evolve): Remove docstrings of dispatched functions. * 📝 docs (evolve): Change docstring. * 🔧 refactor (evolve): Add warning. * Update doc/releases/changelog-dev.md * ✏️ chore (changelog): Add deprecation entry. * ✏️ chore (changelog): Add changelog entry. * 📝 docs (evolve): Change docstring. * Update pennylane/ops/functions/evolve.py --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
This PR does the following:
singledispatch
to dispatchqml.evolve
intoparametrized_evolution
andevolution
, each with its necessary arguments.-1
when usingqml.evolve
with anOperator
, to be consistent withParametrizedEvolution
.Evolution.__init__
redirecting users toqml.evolve
.Evolution.__init__
when usingqml.evolve
.ParametrizedEvolution.time
argument.