-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParametrizedEvolution
: Use params
in super
call
#3730
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the quick mod!
Could you add a test that checks the difference in behaviour within a tape between a ParametrizedEvolution
that has been called and one that hasn't?
Codecov Report
@@ Coverage Diff @@
## master #3730 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 329 329
Lines 28759 28829 +70
=======================================
+ Hits 28683 28753 +70
Misses 76 76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to return a new operator! I think this makes the handling nicer :)
Just two tiny questions left to approve (see comments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AlbertMitjans !
* ✨ feat (ParametrizedEvolution): Use params as trainable parameters. * ✏️ chore (changelog): Add changelog entry. * 🧪 tests (ParametrizedEvolution): change test. * 🧪 tests (evolve): Fix test. * 🚀 perf (ParametrizedEvolution): Return a new instance in __call__. * ✏️ chore (changelog): Add changelog entry. * 🔧 refactor (ParametrizedEvolution): Improve dict concatenation. * 🧪 tests (ndim): Add test.
Use
params
insuper().__init__
call to update thenum_params
attribute.