Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make drive non user-facing #4021

Merged
merged 10 commits into from
Apr 21, 2023
Merged

Make drive non user-facing #4021

merged 10 commits into from
Apr 21, 2023

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Apr 21, 2023

Making drive non user-facing.
Pro:

  • functionality already provided by rydberg_drive or transmon_drive(amp, phase, 0, wires)
  • less maintenance

Con:

  • one off extra work: for code quality it would make sense to remove the function alltogether and just have rydberg_drive
  • lose the nice "theoretical background page that relates the Hamiltonians for different conventions / fields (though could still keep/move those in rydberg_drive and transmon_drive

Background:
Originally thought we could unify all drives because they are doing the same. While this is indeed the case, it makes sense to have different functions for different physical systems because conventions are different. I.e. for Rydberg atoms where all qubits have the same energy gap, it makes more sense to talk about detuning from that uniform energy gap (/frequency). For transmons that is not the case, and different qubits have different resonance frequencies. Hence the drive frequency is used explicitly.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #4021 (5e39d27) into master (a87fca3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4021   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         351      351           
  Lines       30850    30850           
=======================================
  Hits        30721    30721           
  Misses        129      129           
Impacted Files Coverage Δ
pennylane/pulse/__init__.py 100.00% <ø> (ø)
pennylane/pulse/transmon.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Korbinian!

pennylane/pulse/transmon.py Outdated Show resolved Hide resolved
@mudit2812 mudit2812 enabled auto-merge (squash) April 21, 2023 17:26
@mudit2812 mudit2812 disabled auto-merge April 21, 2023 17:26
@mudit2812 mudit2812 enabled auto-merge (squash) April 21, 2023 17:26
@albi3ro albi3ro added this to the Release v0.30 milestone Apr 21, 2023
@mudit2812 mudit2812 added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Apr 21, 2023
@mudit2812 mudit2812 merged commit 763b33e into master Apr 21, 2023
@mudit2812 mudit2812 deleted the remove-drive branch April 21, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants