-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make drive
non user-facing
#4021
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4021 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 351 351
Lines 30850 30850
=======================================
Hits 30721 30721
Misses 129 129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Korbinian!
Making
drive
non user-facing.Pro:
rydberg_drive
ortransmon_drive(amp, phase, 0, wires)
Con:
rydberg_drive
rydberg_drive
andtransmon_drive
Background:
Originally thought we could unify all drives because they are doing the same. While this is indeed the case, it makes sense to have different functions for different physical systems because conventions are different. I.e. for Rydberg atoms where all qubits have the same energy gap, it makes more sense to talk about detuning from that uniform energy gap (/frequency). For transmons that is not the case, and different qubits have different resonance frequencies. Hence the drive frequency is used explicitly.