[BUGFIX] Fix TF shape computation for pauli_decompose
#4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4493 +/- ##
==========================================
- Coverage 99.71% 99.71% -0.01%
==========================================
Files 378 378
Lines 34253 34242 -11
==========================================
- Hits 34155 34144 -11
Misses 98 98
|
|
could you add a quick test for what was failing before? maybe.. do it for jax/torch as well just to be extra sure? otherwise this sounds good to me 👍 |
Jaybsoni
reviewed
Aug 18, 2023
obliviateandsurrender
added
the
merge-ready ✔️
mlxd
pushed a commit
that referenced
this pull request
Aug 23, 2023
* fix `shape` bug * update `PR` number * trigger * change `type` * add more tests * parametrize prettify * suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: There was an
ifcondition inherited from the old legacy code where we were accessing shape viaH.shape. This would fail for tensors built with TensorFlow.Description of the Change: This PR fixes it by using
qml.math.shapeinstead.Benefits: Differentiability on TensorFlow backend.
Possible Drawbacks: N/A
Related GitHub Issues: N/A