-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include results on tracker for default.qubit #4649
Conversation
Hello. You may have forgotten to update the changelog!
|
From the perspective of a user this just makes |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 376 376
Lines 33647 33648 +1
=======================================
+ Hits 33523 33524 +1
Misses 124 124
☔ View full report in Codecov by Sentry. |
[sc-46914] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably just update the changelog entry that's already about the tracker:
* `default.qubit` now tracks the number of equivalent qpu executions and total shots
when the device is sampling. Note that `"simulations"` denotes the number of simulation passes, where as
`"executions"` denotes how many different computational bases need to be sampled in.
[(#4628)](https://github.com/PennyLaneAI/pennylane/pull/4628)
But after adding this PR to that entry, I'd be happy to approve.
DQL included results in the tracker, DQ2 currently does not. Results for each call of
execute
added here.