Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include results on tracker for default.qubit #4649

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Oct 4, 2023

DQL included results in the tracker, DQ2 currently does not. Results for each call of execute added here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542
Copy link
Contributor Author

From the perspective of a user this just makes default.qubit keeps doing a thing that it already did already, so I didn't add a changelog entry for this one

@lillian542 lillian542 marked this pull request as ready for review October 5, 2023 13:55
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (751400d) 99.63% compared to head (110a895) 99.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4649   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         376      376           
  Lines       33647    33648    +1     
=======================================
+ Hits        33523    33524    +1     
  Misses        124      124           
Files Coverage Δ
pennylane/devices/default_qubit.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 requested a review from a team October 5, 2023 15:02
@lillian542
Copy link
Contributor Author

[sc-46914]

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just update the changelog entry that's already about the tracker:

* `default.qubit` now tracks the number of equivalent qpu executions and total shots
  when the device is sampling. Note that `"simulations"` denotes the number of simulation passes, where as
  `"executions"` denotes how many different computational bases need to be sampled in.
  [(#4628)](https://github.com/PennyLaneAI/pennylane/pull/4628)

But after adding this PR to that entry, I'd be happy to approve.

@lillian542 lillian542 enabled auto-merge (squash) October 6, 2023 17:49
@lillian542 lillian542 merged commit c1f9dfa into master Oct 6, 2023
39 checks passed
@lillian542 lillian542 deleted the results-on-tracker branch October 6, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants